Fix incorrect mutability in GUC assign hook macro#2356
Merged
Conversation
cbandy
commented
Jul 14, 2026
The assign hook for strings requires a `const char *` rather than `char *`. This adds `RawConst` and `from_raw_const` to the `GucValue` trait for the `pg_guc_hook(assign)` macro to use. Tests for the `pg_guc_hook` macro are now generated in `pgrx-unit-tests` and include all `GucValue` types.
eeeebbbbrrrr
approved these changes
Jul 15, 2026
Contributor
|
once again, thanks @cbandy! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The assign hook for strings requires a
const char *rather thanchar *. This addsRawConstandfrom_raw_constto theGucValuetrait for thepg_guc_hook(assign)macro to use.Tests for the
pg_guc_hookmacro are now generated inpgrx-unit-testsand include allGucValuetypes.